PER-9361-Email and phone verification are broken; #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the way isLoggedIn is handled in the verify component and made sure that keepLoggedIn is not being set to null after phone or mail verification
meisekimiu
approved these changes
Sep 28, 2023
| instance.setAccount(account); | ||
|
|
||
| await instance.verifyEmail('sampleToken'); | ||
| expect(instance.getAccount().emailStatus).toBe('status.auth.verified'); |
There was a problem hiding this comment.
Suggested change
| expect(instance.getAccount().emailStatus).toBe('status.auth.verified'); | |
| expect(instance.getAccount().emailStatus).toBe('status.auth.verified'); | |
| expect(instance.getAccount().keepLoggedIn).toBeTrue(); |
Let's add a check for the keepLoggedIn behavior since that's what this particular ticket is all about. These tests otherwise just check for email/phone verification, and so pass even when copied over to the main branch. I'd like to see these tests fail if we run them if the specific bug addressed in this ticket isn't fixed, if that makes sense.
| instance.setAccount(account); | ||
|
|
||
| await instance.verifyEmail('sampleToken'); | ||
| expect(instance.getAccount().phoneStatus).toBe('status.auth.verified'); |
There was a problem hiding this comment.
Suggested change
| expect(instance.getAccount().phoneStatus).toBe('status.auth.verified'); | |
| expect(instance.getAccount().phoneStatus).toBe('status.auth.verified'); | |
| expect(instance.getAccount().keepLoggedIn).toBeTrue(); |
k8lyn6
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way isLoggedIn is handled in the verify component and made sure that keepLoggedIn is not being set to null after phone or mail verification.
Steps to test:
1.Log in or create a new account.
2. Verify your email.
3. Refresh.
The button should not appear a second time now.